Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a scheduling_group_name filter to the overview dashboard #1940

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

amnonh
Copy link
Collaborator

@amnonh amnonh commented Mar 22, 2023

This series make the metric related scheduling_group filtered with a default value.
This makes it clearer what are the real latencies and what are internal latencies
Fixes #1939

@amnonh amnonh merged commit 0b1dbc2 into scylladb:master Mar 22, 2023
@amnonh amnonh deleted the choose_sg branch March 22, 2023 08:57
@mykaul
Copy link
Contributor

mykaul commented Mar 22, 2023

Are there any other internal latency metrics we take into account that we should exclude as well?

@amnonh
Copy link
Collaborator Author

amnonh commented Mar 22, 2023

I addressed it with two approaches:

  1. I excluded all the current internal scheduling group
  2. the filter allows you to choose which scheduling group are take in to account.

@amnonh amnonh added this to the Monitoring 4.4 milestone May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove internal sg from p99 in the overview and allow choosing the relevant SG
2 participants