Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-cache): use netip.Addr to unify the IPv6 #4269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karol-kokoszka
Copy link
Collaborator

Fixes #4181

This PR uses netip.Addr to try to parse the host parameter (that can be both, IP or DNS).
If it is able to parse the IP, it keeps this parsed IP (as string) as a key.
If it's not able to parse the IP, original string is kept as a key.


Please make sure that:

  • Code is split to commits that address a single change
  • Commit messages are informative
  • Commit titles have module prefix
  • Commit titles have issue nr. suffix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't identify host by IP string in config cache svc
1 participant