Testing: use UUID based SSTables for testing #4197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UUID SSTables are the default in newer Scylla version, so we should focus on testing them and mock integer based SSTables when needed. Ref #4182
It's useful for scenarios where we want to fail the test in case of response interceptor error, which is difficult to achieve without returning error response.
Michal-Leszczynski
changed the title
This way we are able to cover mixed scenarios (integer + UUID SSTables), which was missing from our test coverage. It also allows us to move to testing the default UUID SSTables, which should be our priority. Fixes #4182
Michal-Leszczynski
force-pushed
the
ml/fix-4182
branch
from
31cf41c to
ad75906
Compare
karol-kokoszka
approved these changes
Jan 20, 2025
VAveryanov8
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes SM tests run against UUID SSTables.
It adds a method for creating artificial integer SSTables that is used for testing versioned backup/restore behavior.
Fixes #4182