fix(gh-actions): Upload gemini results to github #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. When we run integrations tests, there was a bug when uploading gemini results to github actifacts. Issue was in `Makefile`, path to the `./results` is relative to the `./bin` directory from where `gemini` is run. This directory does not exist in `./bin`. Easy fix is just to use `$(PWD)`. 2. Modified the command for `integrations-tests` to match whats running inside SCT (mainly added `--schema-seed` to be the same as the `--seed`). 3. We migrated to `Makefile` fully, there is no need to have `./scripts` They are broken, and all commands have been migrated. Signed-off-by: Dusan Malusev <[email protected]>
CodeLieutenant
force-pushed
the
fix--integrations-tests
branch
from
f010672 to
eb4ac6b
Compare
Signed-off-by: Dusan Malusev <[email protected]>
dkropachev
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run integrations tests, there was a bug when uploading
gemini results to github actifacts. Issue was in
Makefile, path tothe
./resultsis relative to the./bindirectory from wheregeminiis run. This directory does not exist in
./bin.Easy fix is just to use
$(PWD).Modified the command for
integrations-teststo match whats runninginside SCT (mainly added
--schema-seedto be the same as the--seed).We migrated to
Makefilefully, there is no need to have./scriptsThey are broken, and all commands have been migrated.