fix(inflight): reduce memory footprint by using struct{} instead of bool #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
reduce_inflight_footprint
branch
from
517775f to
2f1f23e
Compare
vponomaryov
approved these changes
May 1, 2023
inflight/inflight_test.go
Outdated
| @@ -82,6 +83,25 @@ func TestInflight(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| //go:norace | |||
| func TestInflight_AutoShrink(t *testing.T) { | |||
There was a problem hiding this comment.
Usage of the underscore is not conventional in golang. Maybe better to replace it with, for example, With?
TestInflightWithAutoShrink ?
dkropachev
force-pushed
the
reduce_inflight_footprint
branch
from
2f1f23e to
1002c2c
Compare
dkropachev
pushed a commit
that referenced
this pull request
May 4, 2023
fruch
added a commit
to fruch/scylla-cluster-tests
that referenced
this pull request
May 8, 2023
Update packages and golang (scylladb/gemini#296) Fix(inflight): reduce memory footprint by using struct{} instead of bool (scylladb/gemini#291) Fix warmup hunging (scylladb/gemini#292)
8 tasks
fruch
added a commit
to fruch/scylla-cluster-tests
that referenced
this pull request
May 8, 2023
Update packages and golang (scylladb/gemini#296) Fix(inflight): reduce memory footprint by using struct{} instead of bool (scylladb/gemini#291) Fix warmup hunging (scylladb/gemini#292)
roydahan
pushed a commit
to scylladb/scylla-cluster-tests
that referenced
this pull request
May 17, 2023
Update packages and golang (scylladb/gemini#296) Fix(inflight): reduce memory footprint by using struct{} instead of bool (scylladb/gemini#291) Fix warmup hunging (scylladb/gemini#292)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce memory foot print for
inflightregistry by usingstruct{}instead ofboolAlso add test for shrinking