Plotting of continuous values when norm=None #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
==========================================
+ Coverage 78.58% 78.99% +0.41%
==========================================
Files 11 11
Lines 1312 1314 +2
==========================================
+ Hits 1031 1038 +7
+ Misses 281 276 -5
|
added 2 commits
December 12, 2023 20:46
|
@timtreis could you please have a look at the bugfix? It works now, but there was still an open TODO in the code and I'm not sure what the intention for the original first case was... |
|
Amazing @Sonja-Stockhaus! Thanks for the fix 😊 Since the todo was there also before the fix I would merge now and eventually circle back later. |
|
@LucaMarconato okay, thanks for the feedback! |
timtreis
approved these changes
Jan 9, 2024
timtreis
deleted the
bugfix/issue165-cannot-plot-continuous-var-values-to-labels
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a case to set norm when
norm=Noneinutils._prepare_cmap_norm