Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use umi_count instead of duplicate_count in compliance with AIRR v1.4 #487

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

grst
Copy link
Collaborator

@grst grst commented Jan 26, 2024

  • Remove index_chains_legacy because the numba implemenation seems to work fine
  • Use 'umi_count' instead of 'duplicate_count'

Closes #478

  • CHANGELOG.md updated
  • Tests added (For bug fixes or new features)
  • Tutorial updated (if necessary)

@grst
Copy link
Collaborator Author

grst commented Jan 26, 2024

@zktuong, @amoschoomy, FYI in this PR I update scirpy to use umi_count instead of duplicate_count which is recommended since AIRR v1.4 (see release notes). Maybe you want to do the same thing in Dandelion?

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84f390f) 80.50% compared to head (e85f437) 81.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
+ Coverage   80.50%   81.04%   +0.53%     
==========================================
  Files          49       49              
  Lines        4012     3972      -40     
==========================================
- Hits         3230     3219      -11     
+ Misses        782      753      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grst grst merged commit d776d01 into main Jan 29, 2024
11 checks passed
@grst grst deleted the airr-umi-count branch January 29, 2024 09:02
@amoschoomy amoschoomy mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Where has UMI count for AIR chains gone?
1 participant