Add Pylint lints #3577
Merged
Add Pylint lints #3577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flying-sheep
added
Development Process 🚀
needs retroactive review
17 tasks
flying-sheep
commented
Apr 11, 2025
Comment on lines
-461
to
+459
| for ikey, palette in zip(categoricals, palettes, strict=False): | ||
| for ikey, pal in zip(categoricals, palettes, strict=False): |
There was a problem hiding this comment.
PLW2901 (redefined-loop-name) is great to disentangle hairy code!
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3577 +/- ##
==========================================
+ Coverage 75.48% 75.53% +0.05%
==========================================
Files 113 113
Lines 13169 13147 -22
==========================================
- Hits 9941 9931 -10
+ Misses 3228 3216 -12
|
meeseeksmachine
pushed a commit
to meeseeksmachine/scanpy
that referenced
this pull request
Apr 11, 2025
flying-sheep
added a commit
that referenced
this pull request
Apr 11, 2025
Co-authored-by: Philipp A <[email protected]>
selmanozleyen
pushed a commit
to selmanozleyen/scanpy
that referenced
this pull request
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See scverse/anndata#1241