Skip to content

Allow all valid legend_loc options #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Allow all valid legend_loc options #3163

merged 4 commits into from
Jul 25, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Jul 25, 2024

  • Release notes not necessary because:

Also

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.52%. Comparing base (4269ed2) to head (6801394).
Report is 56 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3163   +/-   ##
=======================================
  Coverage   76.52%   76.52%           
=======================================
  Files         109      109           
  Lines       12480    12483    +3     
=======================================
+ Hits         9550     9553    +3     
  Misses       2930     2930           
Files with missing lines Coverage Δ
src/scanpy/plotting/_anndata.py 85.02% <100.00%> (ø)
src/scanpy/plotting/_docs.py 100.00% <ø> (ø)
src/scanpy/plotting/_tools/paga.py 66.98% <ø> (ø)
src/scanpy/plotting/_tools/scatterplots.py 86.99% <100.00%> (+0.05%) ⬆️
src/scanpy/plotting/_utils.py 55.86% <100.00%> (+0.08%) ⬆️

@flying-sheep flying-sheep added this to the 1.10.3 milestone Jul 25, 2024
@flying-sheep flying-sheep requested a review from Intron7 July 25, 2024 08:35
@flying-sheep flying-sheep marked this pull request as ready for review July 25, 2024 09:11
@flying-sheep flying-sheep merged commit 9fa55b8 into main Jul 25, 2024
12 of 14 checks passed
@flying-sheep flying-sheep deleted the fix-legend-loc branch July 25, 2024 09:41
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Jul 25, 2024
flying-sheep added a commit that referenced this pull request Jul 25, 2024
@flying-sheep flying-sheep self-assigned this Aug 1, 2024
kaushalprasadhial pushed a commit to sanchit-misra/scanpy that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment