Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum dependency test job #2816
Minimum dependency test job #2816
Changes from 8 commits
141eb6a
a07568e
705acfe
9a0dd1a
e4dbcbc
355c904
a8bd01b
d36b977
6b4823c
efa8a39
6b7a37f
47beebe
1a5d701
4b04a76
27fb272
4e61bea
ed71b11
cb95628
f29be77
483129b
199cefc
098fea3
1cb9396
079ad46
5d7494a
cadd7db
4a7784c
f9cad08
3b8db82
78c7ee9
e46911c
e01eb01
aa2dd50
e598ce7
debfc4b
0112aa5
70e5866
bbdddf2
eef7055
70d151d
cb36a62
2bf0789
07f6d57
5090fff
907544e
208d413
826d3dd
e4ee55d
2b74f41
aa4eda0
0ee1ced
264aa9a
6693773
b412bfb
bacb2e7
b6afd99
c7d95b6
0ddc5e2
b653dd6
2b2ec5d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change? you do e.g
numba>=0.56
tooThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically because the
min-deps.py
script is hacky, and is appending.*
to the end of the version it finds here. I am aiming for testing against the latest bugfix release within a release series (at least for projects that do semantic versioning).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn’t sound good, I don’t think it should break if we specify
>=1.2.4
somewhere because that patch release has some patch we rely on.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't break, it will try to install
1.2.4.*
which finds1.2.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it won’t be what we want, that would be
>=1.2.4, <1.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, we can still do that with the existing code. It just means the CI tests against that bugfix release specifically and not whatever is the latest from pypi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how we can both pin a minimum bugfix release and test against the latest in a release series from pypi. If all our dependencies followed semver, then this would be easy since we could just strip the bugfix release number from the specification when making the environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That means that we can’t do this unless we annotate for every project if it’s semver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Do you have a specific change here that you would like to see?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see below, this is too fundamental for a thread.