Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start fixing metric tests #2705

Merged
merged 7 commits into from
Jan 26, 2024
Merged

Conversation

ivirshup
Copy link
Member

@ivirshup ivirshup commented Oct 24, 2023

  • Release notes not necessary because: just modifying tests

Fixes tests for metrics

Some notes on an in progress PR:

  • Previously xfail tests didn't actually fail because nothing was asserted
  • This behavior changes with version of numba.
    • numba .56<= seems more reproducible, but differences are greater when they occur (e.g. calculating on sparse vs dense)
  • Ideally want per metric, per calculation tolerances
  • Both threading options can differer
  • I think single threaded + fastmath=False is reproducible, but need to confirm – still no

@ivirshup ivirshup added Area – Reproducibility Exact replication Area - Topology 🍩 Neighbor graphs labels Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf5f27a) 72.72% compared to head (28c2def) 72.72%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2705   +/-   ##
=======================================
  Coverage   72.72%   72.72%           
=======================================
  Files         111      111           
  Lines       12383    12383           
=======================================
  Hits         9005     9005           
  Misses       3378     3378           
Files Coverage Δ
scanpy/plotting/_utils.py 56.33% <100.00%> (ø)

@ivirshup ivirshup added this to the 1.10.0 milestone Jan 22, 2024
@ivirshup ivirshup mentioned this pull request Jan 22, 2024
6 tasks
@ivirshup ivirshup marked this pull request as ready for review January 26, 2024 14:52
@ivirshup ivirshup enabled auto-merge (squash) January 26, 2024 16:52
@ivirshup ivirshup merged commit 96e1954 into scverse:master Jan 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Topology 🍩 Neighbor graphs Area – Reproducibility Exact replication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics started returning inconsistent results
2 participants