Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scanpy 1.10 compat + PR CI #136

Merged
merged 12 commits into from
Apr 9, 2024
Merged

scanpy 1.10 compat + PR CI #136

merged 12 commits into from
Apr 9, 2024

Conversation

ivirshup
Copy link
Member

@ivirshup ivirshup commented Mar 28, 2024

  • FIX: replace scanpy.neighbors._compute_connectivities_umap with scanpy.neighbors._connectivity.umap
  • Change for black
  • fix for _choose_representation arguments
  • update CI to run on PRs
  • release note

Fixes #135.

Changes proposed in this pull request:

@grst
Copy link
Contributor

grst commented Apr 4, 2024

Depends on bioFAM/mofapy2#23

@grst
Copy link
Contributor

grst commented Apr 4, 2024

@gtca can you please merge the two open PRs to mofapy2 and make a patch release?

@gtca gtca merged commit 3dace03 into master Apr 9, 2024
4 checks passed
@gtca
Copy link
Collaborator

gtca commented Apr 9, 2024

Thanks a lot, everyone!
(@milescsmith, @ivirshup, @flying-sheep, @grst)

@flying-sheep flying-sheep deleted the fix-plus branch April 9, 2024 09:47
@flying-sheep
Copy link
Member

you should release that before we release the next scanpy minor version and muon breaks for people!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name '_compute_connectivities_umap' from 'scanpy.neighbors'
5 participants