Hdf5r rownames rework

DESCRIPTION

@@ -68,7 +68,7 @@ Suggests:
     BiocStyle,
     knitr,
     reticulate,
-    rhdf5,
+    hdf5r,
     rmarkdown,
     S4Vectors,
     SeuratObject,
@@ -85,3 +85,4 @@ Encoding: UTF-8
 Roxygen: list(markdown = TRUE, r6 = TRUE)
 RoxygenNote: 7.2.3
 biocViews: SingleCell, DataImport, DataRepresentation
+Remotes: github::hhoeflin/hdf5r@bug/fix_empty_attrs_again

R/AbstractAnnData.R

@@ -284,13 +284,6 @@ AbstractAnnData <- R6::R6Class("AbstractAnnData", # nolint
         ))
       }
 
-      if (has_row_names(df)) {
-        warning(wrap_message(
-          "'", label, "' should not have any rownames, removing them from the data frame."
-        ))
-        rownames(df) <- NULL
-      }
-
       df
     },
 

R/AnnData.R

@@ -8,14 +8,7 @@
 #'
 #' To read an AnnData file from disk, use [read_h5ad()] instead.
 #'
-#' @param obs_names A vector of unique identifiers
-#'   used to identify each row of `obs` and to act as an index into the
-#'   observation dimension of the AnnData object. The length of `obs_names`
-#'   defines the observation dimension of the AnnData object.
-#' @param var_names A vector of unique identifiers used to identify each row
-#'   of `var` and to act as an index into the variable dimension of the
-#'   AnnData object. The length of `var_names` defines the variable
-#'   dimension of the AnnData object.
+#' @param  AnnData object.
 #' @param X Either `NULL` or a observation × variable matrix with
 #'   dimensions consistent with `obs` and `var`.
 #' @param layers Either `NULL` or a named list, where each element is an
@@ -46,22 +39,20 @@
 #'
 #' @examples
 #' adata <- AnnData(
-#'   obs_names = paste0("obs", 1:3),
-#'   var_names = paste0("var", 1:4),
 #'   X = matrix(1:12, nrow = 3, ncol = 4),
 #'   obs = data.frame(
+#'     row.names = paste0("obs", 1:3),
 #'     n_counts = c(1, 2, 3),
 #'     n_cells = c(1, 2, 3)
 #'   ),
 #'   var = data.frame(
+#'     row.names = paste0("var", 1:4),
 #'     n_cells = c(1, 2, 3, 4)
 #'   )
 #' )
 #'
 #' adata
 AnnData <- function(
-    obs_names = NULL,
-    var_names = NULL,
     X = NULL,
     obs = NULL,
     var = NULL,
@@ -72,8 +63,6 @@ AnnData <- function(
     varp = NULL,
     uns = NULL) {
   InMemoryAnnData$new(
-    obs_names = obs_names,
-    var_names = var_names,
     X = X,
     obs = obs,
     var = var,