-
Notifications
You must be signed in to change notification settings - Fork 164
(feat): allow writing from cupy
inside dask
arrays
#1550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ilan-gold
commented
Jul 1, 2024
- Closes GPU writing #1549 (so part of Dask gpu #1480)
- Tests added
- Release note added (or unnecessary)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1550 +/- ##
==========================================
+ Coverage 84.43% 86.56% +2.13%
==========================================
Files 36 36
Lines 5782 5851 +69
==========================================
+ Hits 4882 5065 +183
+ Misses 900 786 -114
|
I'm not sure what's up with codecov. I believe those lines are being hit and when I look at the github GPU job, it says we have reached an upload limit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (but still needs a release note), maybe @Intron7 could take a quick look too on the cupy stuff.
Have you looked into fixing the codecov issue?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
testing.helpers
testing.helpers
cupy
inside dask
arrays + testing.helpers
cupy
inside dask
arrays + testing.helpers
cupy
inside dask
arrays