Skip to content

(feat): allow writing from cupy inside dask arrays #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Jul 12, 2024
Merged

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold self-assigned this Jul 1, 2024
@ilan-gold ilan-gold added this to the 0.10.9 milestone Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.56%. Comparing base (4c70aa8) to head (26a2c21).
Report is 67 commits behind head on main.

Files with missing lines Patch % Lines
src/anndata/tests/helpers.py 94.11% 4 Missing ⚠️
src/anndata/compat/__init__.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1550      +/-   ##
==========================================
+ Coverage   84.43%   86.56%   +2.13%     
==========================================
  Files          36       36              
  Lines        5782     5851      +69     
==========================================
+ Hits         4882     5065     +183     
+ Misses        900      786     -114     
Files with missing lines Coverage Δ
src/anndata/_io/specs/methods.py 88.40% <100.00%> (+0.42%) ⬆️
src/anndata/_io/specs/registry.py 96.31% <100.00%> (+0.04%) ⬆️
src/anndata/compat/__init__.py 84.38% <66.66%> (+0.83%) ⬆️
src/anndata/tests/helpers.py 94.06% <94.11%> (+7.83%) ⬆️

... and 4 files with indirect coverage changes

@ilan-gold
Copy link
Contributor Author

I'm not sure what's up with codecov. I believe those lines are being hit and when I look at the github GPU job, it says we have reached an upload limit:
https://github.com/scverse/anndata/actions/runs/9763035863/job/26947927670?pr=1550

@ilan-gold ilan-gold marked this pull request as ready for review July 3, 2024 09:54
Copy link
Member

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (but still needs a release note), maybe @Intron7 could take a quick look too on the cupy stuff.

Have you looked into fixing the codecov issue?

@ilan-gold
Copy link
Contributor Author

@ilan-gold ilan-gold requested a review from Intron7 July 4, 2024 07:37
Copy link
Member

@Intron7 Intron7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilan-gold ilan-gold modified the milestones: 0.10.9, 0.11.0 Jul 12, 2024
@ilan-gold ilan-gold changed the title (feat): allow gpu writing (feat): allow gpu writing + testing.helpers Jul 12, 2024
@ilan-gold ilan-gold changed the title (feat): allow gpu writing + testing.helpers (feat): allow writing from cupy inside dask arrays + testing.helpers Jul 12, 2024
@ilan-gold ilan-gold changed the title (feat): allow writing from cupy inside dask arrays + testing.helpers (feat): allow writing from cupy inside dask arrays Jul 12, 2024
@ilan-gold ilan-gold merged commit 9918044 into main Jul 12, 2024
15 of 16 checks passed
@ilan-gold ilan-gold deleted the ig/write_dask_gpu branch July 12, 2024 13:09
This was referenced Jul 12, 2024
@ilan-gold ilan-gold mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPU writing
3 participants