-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scully): logrocket render plugin. #680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the thing I highlighted!
Also, shouldn't you define a default config in there?
BTW, you don't need to blush it to be used in scully.
@GuzmanPI I check the test and show this error
|
7e7457b
to
a05ee47
Compare
I'll check the tests |
Fixes tests adds dummy app and id
a05ee47
to
fe9a020
Compare
Add keys for logrocket fix issue undefined values in getMyConfig add prod option for support into scully config change web publisher for publish with logrocket
HeroDevs seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
The docs app uses this plugin.
Implements the pluguin
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
LogRocket plugin for the docs. This may be an npm plugin in the future.
What is the current behavior?
Issue Number: #673
What is the new behavior?
Adds LogRocket's scripts to the tag.
Does this PR introduce a breaking change?
Other information