Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scully): logrocket render plugin. #680

Merged
merged 12 commits into from
Jul 3, 2020
Merged

feat(scully): logrocket render plugin. #680

merged 12 commits into from
Jul 3, 2020

Conversation

GuzmanPI
Copy link
Contributor

@GuzmanPI GuzmanPI commented Jul 1, 2020

The docs app uses this plugin.

Implements the pluguin

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

LogRocket plugin for the docs. This may be an npm plugin in the future.

What is the current behavior?

Issue Number: #673

What is the new behavior?

Adds LogRocket's scripts to the tag.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@GuzmanPI GuzmanPI marked this pull request as draft July 1, 2020 19:23
@GuzmanPI GuzmanPI requested a review from jorgeucano July 1, 2020 19:23
Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the thing I highlighted!
Also, shouldn't you define a default config in there?

BTW, you don't need to blush it to be used in scully.

libs/plugins/logrocket/src/lib/plugins-logrocket.ts Outdated Show resolved Hide resolved
@SanderElias SanderElias self-requested a review July 2, 2020 12:12
@jorgeucano
Copy link
Contributor

@GuzmanPI I check the test and show this error

    +     <script src="https://cdn.logrocket.io/LogRocket.min.js"></script>
    +     <script>window.LogRocket && window.LogRocket.init('undefined/undefined');</script></head>``` 
Please check the config is not working!

@GuzmanPI GuzmanPI force-pushed the logrocket-plugin branch from 7e7457b to a05ee47 Compare July 2, 2020 13:38
@GuzmanPI
Copy link
Contributor Author

GuzmanPI commented Jul 2, 2020

I'll check the tests

Fixes tests adds dummy app and id
@GuzmanPI GuzmanPI force-pushed the logrocket-plugin branch from a05ee47 to fe9a020 Compare July 2, 2020 16:58
Add keys for logrocket
fix issue undefined values in getMyConfig
add prod option for support
into scully config
change web publisher for publish with logrocket
@jorgeucano jorgeucano marked this pull request as ready for review July 2, 2020 19:55
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ GuzmanPI
✅ jorgeucano
❌ HeroDevs


HeroDevs seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jorgeucano jorgeucano merged commit ca35036 into main Jul 3, 2020
@jorgeucano jorgeucano deleted the logrocket-plugin branch July 3, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants