fix(scully): replace falsy check with explicit string check to allow root route #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlindDespair
changed the title
|
|
BlindDespair
commented
Feb 4, 2020
| @@ -46,7 +46,7 @@ export const generateAll = async (localBaseFilter = baseFilter) => { | |||
| performanceIds.add('Discovery'); | |||
| log('Pull in data to create additional routes.'); | |||
| const handledRoutes = await addOptionalRoutes( | |||
| unhandledRoutes.filter((r: string) => r && r.startsWith(localBaseFilter)) | |||
| unhandledRoutes.filter((r: string) => typeof r === 'string' && r.startsWith(localBaseFilter)) | |||
There was a problem hiding this comment.
I am still not sure if this check is needed at all. Maybe it makes sense to just omit it?
There was a problem hiding this comment.
It protects to mistakes in the Scully.config file. so, yes the check is needed. We have no control over the data that is coming from the guess parser, and neither on the config file. If a route is not a string, its pretty safe to ignore it.
There was a problem hiding this comment.
That makes sense, thank you.
|
If you sign the CLA, I can accept this PR. |
I signed it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #275
What is the new behavior?
Does this PR introduce a breaking change?
Other information