Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add learning.dev to the Scully showcase #1493

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Conversation

thomasturrell
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

Add learning.dev to the Scully showcase

What is the current behavior?

N/A

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Add learning.dev to the Scully showcase. I would be grateful if it could be added but I understand if you do not wish to at this time.

@Jefiozie Jefiozie self-requested a review December 13, 2021 06:12
Copy link
Collaborator

@Jefiozie Jefiozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @thomasturrell for adding this.

@Jefiozie Jefiozie merged commit dc6c595 into scullyio:main Dec 14, 2021
@thomasturrell thomasturrell deleted the patch-2 branch December 14, 2021 18:51
@thomasturrell
Copy link
Contributor Author

@Jefiozie I am very thankful for Scully! We are proud to be in the showcase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants