Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Add additional class to error messages in scully-content #228

Closed
jasper-jool opened this issue Jan 23, 2020 · 0 comments · Fixed by #230
Closed

[FEATURE REQUEST] Add additional class to error messages in scully-content #228

jasper-jool opened this issue Jan 23, 2020 · 0 comments · Fixed by #230
Labels
enhancement New feature or request waiting for new publish

Comments

@jasper-jool
Copy link

I'd like to have an option to add an additional class to the scully-content error messages. This can be used for css styling and e2e targeting.
SanderElias added a commit that referenced this issue Jan 24, 2020
@SanderElias
feat(scullycontent): add a detectable Id to scully rendering errors
bda88b8 
This will add a `id="___scully-parsing-error___"` to scully rendering errors, so that it will be
easier to detect those during CI/CD steps.

closes #228
@SanderElias SanderElias mentioned this issue Jan 24, 2020
Merged
10 tasks
SanderElias added a commit that referenced this issue Jan 24, 2020
@SanderElias
feat(scullycontent): add a detectable Id to scully rendering errors (#…
71f8e21 
…230)

* feat(scullycontent): add a detectable Id to scully rendering errors

This will add a `id="___scully-parsing-error___"` to scully rendering errors, so that it will be
easier to detect those during CI/CD steps.

closes #228

* Update scully-content.component.ts

fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request waiting for new publish
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(scullycontent): add a detectable Id to scully rendering errors scullyio/scully
2 participants
@SanderElias @jasper-jool