Add ExtrsinicV5 type #816
Merged
Add ExtrsinicV5 type #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haerdib
force-pushed
the
bh/extrinsic-v5
branch
from
0f850f4 to
ac9ecd7
Compare
haerdib
force-pushed
the
bh/extrinsic-v5
branch
from
ac9ecd7 to
395eb38
Compare
1 task
Niederb
reviewed
Feb 4, 2025
| pub struct SignedPayload<Call, SignedExtra, AdditionalSigned>( | ||
| (Call, SignedExtra, AdditionalSigned), | ||
| ); | ||
| pub struct SignedPayload<Call, SignedExtra, Implicit>((Call, SignedExtra, Implicit)); |
There was a problem hiding this comment.
I think it would be nice to also rename all the SignedExtra-Types in generics. It is also still used in some other places (author.rs, block_builder.rs, transaction_payment.rs)
There was a problem hiding this comment.
Good catch, you're absolutely right
haerdib
force-pushed
the
bh/extrinsic-v5
branch
from
5626ac1 to
88f4c56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo update
Deprecate ExtrinsicV4
Use Extrinsic Type from Substrate directly (V5): Only requirement:
GenericTxExtensionneeds to implement theTransactionExtensionfrom Substrate.merge and rebase Upgrade to ubuntu-latest #823
closes #810