Change dependencies to point to the crates.io versions #755
Conversation
|
@masapr Can you have a look at the meta-infos? I would then revert the dependency paths back to github and then we can actually merge this. |
keystore/README.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| # ac_keystore | |||
|
|
|||
| This crate is a submodule of the [substrate-api-client](https://github.com/scs/substrate-api-client). It contains a fork of the sc-keystore crate and this is in order to access private functions and members of the crate. | |||
There was a problem hiding this comment.
I would write the second sentence like this:
It is a fork of substrate's sc-keystore crate. The substrate-api-client needs its own fork in order to access private functions and members of the crate.
There was a problem hiding this comment.
I split the PR into two and added your suggestion to the new PR. See #757
| sp-application-crypto = { version = "32.0.0" } | ||
| sp-core = { version = "30.0.0" } | ||
| sp-keyring = { version = "33.0.0" } | ||
| sp-keystore = { version = "0.36.0" } |
There was a problem hiding this comment.
This part we only need for the publishing, right? But we want to update the text below in general, is that right?
then this should be two PRs? Resp. only the PR for the text. And the dependencies here would only be adjusted for the branch that is published on crates.io.
There was a problem hiding this comment.
Opened a separate PR. See #757
Niederb
force-pushed
the
tn/publish-keystore
branch
from
41d1a39 to
667fac2
Compare
|
Changes are only needed to release to crates.io. Closing this |
Only for release to crates.io.
Do not merge!