Fix reported extrinsic hash #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haerdib
commented
Jul 24, 2023
| @@ -100,7 +100,6 @@ async fn main() { | |||
| println!("[+] Extrinsic with hash {extrinsic_hash:?} was successfully executed.",); | |||
| println!("[+] Extrinsic got included in block with hash {block_hash:?}"); | |||
| println!("[+] Watched extrinsic until it reached the status {extrinsic_status:?}"); | |||
| println!("[+] The following events were thrown when the extrinsic was executed: {extrinsic_events:?}"); | |||
There was a problem hiding this comment.
Removed this line because the printing was way too verbose.
|
Manual test: Polkadot.js:
|
echevrier
approved these changes
Jul 25, 2023
| let report = api.submit_and_watch_extrinsic_until(xt2, XtStatus::Ready).unwrap(); | ||
| assert_eq!(extrinsic_hash, report.extrinsic_hash); |
echevrier
pushed a commit
that referenced
this pull request
Jul 26, 2023
* fix xt_hash * fix clippy * fix unit test * fix author tests * remove too verbose println (cherry picked from commit 8e92465)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that we encoded the extrinsic twice:
T::Hasher::hash_of(..)encodes the input automatically. We therefore need to useT::Hasher::hash(..)for the already encoded extrinsic.The extrinsic hash can be manually checked by:
docker run -p 9944:9944 -p 9933:9933 -p 30333:30333 parity/substrate:latest --dev --rpc-externalcargo run -p ac-examples --example check_extrinsic_eventscloses #621