Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function get_system_account_next_index #573

Merged
merged 4 commits into from
May 15, 2023
Merged

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented May 11, 2023

Fixes #572

Regarding the // FIXME: Remove once #391 is fixed. : Issue added in #574

@haerdib haerdib self-assigned this May 11, 2023
@haerdib haerdib added F7-enhancement Enhances an already existing functionality E1-breaksnothing labels May 11, 2023
@haerdib haerdib marked this pull request as ready for review May 11, 2023 13:44
@haerdib haerdib requested review from Niederb and echevrier May 11, 2023 13:57
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haerdib haerdib merged commit a878748 into master May 15, 2023
@haerdib haerdib deleted the bh/add-next-index branch May 15, 2023 08:21
@Kailai-Wang
Copy link

Thanks @haerdib - this helps us too! 🚀

@Kailai-Wang
Copy link

Btw would it be possbile to backport it to polkadot-v0.9.39 branch? The worker is still based on that branch :)

@haerdib
Copy link
Contributor Author

haerdib commented May 15, 2023

Sure, I don't think that should be a problem. Let me try that.

haerdib added a commit that referenced this pull request May 15, 2023
* add get_system_account_next_index

* fix account Id traits

* add std feature

* fix test

move get_system_account_next_index to GetAccInformation trait
@haerdib
Copy link
Contributor Author

haerdib commented May 15, 2023

Added here: d872c2c

@Kailai-Wang
Copy link

Big thanks @haerdib 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E1-breaksnothing F7-enhancement Enhances an already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support system_accountNextIndex RPC
4 participants