Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExtrinsicSigner encoding #510

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Fix ExtrinsicSigner encoding #510

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db0553b
add Encode enforcement
haerdib Mar 30, 2023
45e679d
Merge branch 'master' into bh/fix-signature-encoding
haerdib Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions primitives/src/extrinsics/signer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ use sp_core::Pair;
use sp_runtime::traits::StaticLookup;

pub trait SignExtrinsic<AccountId: Clone + Encode> {
type Signature;
type Signature: Encode;
type ExtrinsicAddress: Clone + Encode;

/// Sign a given payload and return the resulting Signature.
Expand Down Expand Up @@ -73,7 +73,7 @@ impl<Signer, Signature, Runtime> SignExtrinsic<Runtime::AccountId>
where
Runtime: FrameSystemConfig,
Signer: Pair,
Signature: From<Signer::Signature>,
Signature: From<Signer::Signature> + Encode,
{
type Signature = Signature;
type ExtrinsicAddress = <Runtime::Lookup as StaticLookup>::Source;
Expand Down