Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 32 bit architectures #478

Merged
merged 6 commits into from
Mar 29, 2023
Merged

Support 32 bit architectures #478

merged 6 commits into from
Mar 29, 2023

Conversation

Niederb
Copy link
Contributor

@Niederb Niederb commented Mar 22, 2023 •
edited
Loading

  • Support en-/decoding to u64 BitVec only on 64 bit architectures
  • Add a CI check to ensure that the code compiles with a 32bit architecture

closes #477

@Niederb Niederb changed the title Experiment with removing the u64 implementations in order to support 32 bit architectures Support 32 bit architectures Mar 24, 2023
@Niederb Niederb requested a review from haerdib March 24, 2023 08:48
@Niederb
Copy link
Contributor Author

Niederb commented Mar 24, 2023

@haerdib Can you have a look? I would rebase once master is working again and then we can merge it.

haerdib
haerdib approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add - awesome !

@Niederb Niederb force-pushed the tn/support-32-bit branch from 81c7893 to b30df75 Compare March 29, 2023 13:08
@Niederb Niederb marked this pull request as ready for review March 29, 2023 13:49
@Niederb Niederb requested a review from echevrier March 29, 2023 13:49
echevrier
echevrier approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Niederb Niederb merged commit 9a79c75 into master Mar 29, 2023
@haerdib haerdib added the F8-newfeature Introduces a new feature label Apr 4, 2023
@Niederb Niederb deleted the tn/support-32-bit branch April 5, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haerdib haerdib haerdib approved these changes

@echevrier echevrier echevrier approved these changes

Assignees
No one assigned
Labels
E1-breaksnothing F8-newfeature Introduces a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support 32bit architectures
3 participants
@Niederb @haerdib @echevrier