Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl From<Vec<u8>> for StorageKey and remove <Hash> from Balance Trait #471

Merged
merged 2 commits into from
Mar 6, 2023
Merged

impl From<Vec<u8>> for StorageKey and remove <Hash> from Balance Trait #471

merged 2 commits into from
Mar 6, 2023

Conversation

echevrier
Copy link
Contributor

@echevrier echevrier added the E0-silent Will not be mentioned in the release label Mar 6, 2023
@echevrier echevrier requested a review from haerdib March 6, 2023 13:32
haerdib
haerdib reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@haerdib haerdib left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks !

Only some minor comments:

  • could you adapt the PR title to describe what you're fixing instead of linking issues?
  • could you link the issues that are being closed by this PR? (e.g. closes #...)
  • The label E0-silent should only be used for things that do not change functional code. Things like updating documentation, CI, and similar. For code changes that do not break anything, please use the label E1-breaksnothing.
    The reason is: E0 labels will not be added in the automatic release text, which describes what has changed compared to the previous releae. Whereas E1 <= labels will be added.

This was linked to issues Mar 6, 2023
impl From<Vec<u8>> for StorageKey #455
Closed
Remove <Hash> from Balance Trait of api_rpc #465
Closed
@echevrier echevrier added E1-breaksnothing and removed E0-silent Will not be mentioned in the release labels Mar 6, 2023
@echevrier echevrier changed the title fix trivial issues #455 and #465 impl From<Vec<u8>> for StorageKey and remove <Hash> from Balance Trait Mar 6, 2023
@echevrier echevrier requested a review from haerdib March 6, 2023 15:03
haerdib
haerdib approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks !

@echevrier echevrier merged commit 788822c into master Mar 6, 2023
@echevrier echevrier deleted the ec/trivial_issues branch March 6, 2023 15:11
@haerdib haerdib added the F7-enhancement Enhances an already existing functionality label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haerdib haerdib haerdib approved these changes

Assignees
No one assigned
Labels
E1-breaksnothing F7-enhancement Enhances an already existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove <Hash> from Balance Trait of api_rpc impl From<Vec<u8>> for StorageKey
2 participants
@echevrier @haerdib