Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetAccountInformation has no contraint on Signer #458

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

masapr
Copy link
Collaborator

@masapr masapr commented Feb 10, 2023

closes #451

@masapr masapr added F7-enhancement Enhances an already existing functionality E1-breaksnothing labels Feb 10, 2023
@masapr masapr requested a review from haerdib February 10, 2023 16:16
@masapr masapr self-assigned this Feb 10, 2023
Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Could you update the PR title though? The traits name is GetAccountInformation

@masapr masapr changed the title get_account_data has no contraint on Signer GetAccountData has no contraint on Signer Feb 13, 2023
@masapr masapr changed the title GetAccountData has no contraint on Signer GetAccountInformation has no contraint on Signer Feb 13, 2023
@masapr masapr marked this pull request as ready for review February 13, 2023 08:33
@masapr masapr merged commit adda0d9 into master Feb 13, 2023
@masapr masapr deleted the sp/remove_constrain_signer branch February 13, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E1-breaksnothing F7-enhancement Enhances an already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetAccountData should not constrain Signer: SignExtrinsic
2 participants