Make api/rpc interfaces no_std compatible #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haerdib
commented
Dec 19, 2022
| @@ -15,11 +15,7 @@ | |||
|
|
|||
| */ | |||
|
|
|||
| #[cfg(not(feature = "std"))] | |||
There was a problem hiding this comment.
std::string::String points to alloc::string::String as well. So I removed this obsolete condition completely.
haerdib
changed the title
clangenb
approved these changes
Dec 20, 2022
primitives/src/rpc_params.rs
Outdated
Comment on lines
147
to
152
| #[cfg(not(feature = "std"))] | ||
| /// Insert a plain value into the builder with heap allocation. If available, | ||
| /// use the more efficient std version. | ||
| pub(crate) fn insert<P: Serialize>(&mut self, value: P) -> Result<()> { | ||
| self.insert_with_allocation(value) | ||
| } |
There was a problem hiding this comment.
Usually the doc is above the feature flag
|
Good point. But maybe a full cleanup would be sensible, as propagating Strings is also not very efficient, I suppose. I commented in #317 accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step further towards
no_stdcompatibility:compsoe-macrosis now fullyno_stdcompatibleapi/rpcis now fullyno_stdcompatibleprimitives-typesimport inCargo.tomlDrawbacks:
thiserrorneeded to be changed tothiserror-core. But that should be temporary only. And better than removing it completely (I hope).no_std.one step towards #279