Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ws-client feature flag for impl block #258

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Conversation

gaudenzkessler
Copy link
Contributor

@gaudenzkessler gaudenzkessler commented Jun 28, 2022

The value NodeApi used in the impl block has already the very same feature flag.

@gaudenzkessler gaudenzkessler requested a review from murerfel June 28, 2022 15:17
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@murerfel murerfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murerfel murerfel merged commit 7b56455 into master Jun 29, 2022
@murerfel murerfel deleted the gk/ws-client-flag branch June 29, 2022 07:14
echevrier added a commit that referenced this pull request Jul 11, 2022
* Add ws-client feature flag for impl block (#258)

* Add ws-client feature flag for impl block

* update rust

Co-authored-by: Gaudenz Kessler <[email protected]>

* Expose `disable_target_static_assertions` feature flag  (#257)

* [api-client] explicitly disable target static assertions in ap-client

* make disable_target_static_assertions and optional feature

* [test-no-std] say how it needs to be used.

* Metadata sgx compatible (#259)

* make metadata compatible with no_std

* include node-metadata in api-client root crate without std

* Clippy changes

Co-authored-by: echevrier <[email protected]>

Co-authored-by: gaudenzkessler <[email protected]>
Co-authored-by: Gaudenz Kessler <[email protected]>
Co-authored-by: clangenb <[email protected]>
Co-authored-by: echevrier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants