Circuit for opcode SELFBALANCE #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icemelon
approved these changes
Feb 4, 2022
| @@ -648,6 +648,8 @@ fn tx_convert( | |||
| tx: &bus_mapping::circuit_input_builder::Transaction, | |||
| ops_len: (usize, usize, usize), | |||
| ) -> Transaction<Fp> { | |||
| // look in to addresses here? | |||
| // callee address?? | |||
There was a problem hiding this comment.
I will remove this comment. I think that privacy-scaling-explorations#292 will address this, which should allow us to use run_test_circuits for the gadget test instead of having to construct the witness by hand.
|
I'm waiting for privacy-scaling-explorations#292 to be merged in. I will need to update the bus mapping for SELFBALANCE once it is, because we need to do account and call context lookups for the opcode. |
|
decided that this is ready for review and that i'll update the bus mapping for SELFBALANCE once privacy-scaling-explorations#292 is merged in upstream. |
|
close and move to privacy-scaling-explorations#328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the SelfbalanceGadget for opcode SELFBALANCE.
Specs: scroll-tech/zkevm-specs#33
Fixes #56