Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codecv1): add commit gas and calldata size estimation #1324

Merged
merged 11 commits into from
May 7, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented May 6, 2024

Purpose or design rationale of this PR

  1. add codecv1 commit calldata size and gas estimations.
  2. add calldata size and gas limits in chunk & batch-proposers.
  3. update l2geth dependency to reduce blob copy ops.
  4. more accurate blob usage for better analysis.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@colinlyguo colinlyguo changed the title feat(codecv1): add commit gas and calldata size estimation and limits feat(codecv1): add commit gas and calldata size estimation May 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 95.41284% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 54.21%. Comparing base (54415f6) to head (6b44193).

Files Patch % Lines
rollup/internal/utils/utils.go 0.00% 4 Missing ⚠️
common/types/encoding/codecv1/codecv1.go 99.01% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1324      +/-   ##
===========================================
- Coverage    56.23%   54.21%   -2.02%     
===========================================
  Files          160       65      -95     
  Lines        12438     6743    -5695     
===========================================
- Hits          6994     3656    -3338     
+ Misses        4912     2731    -2181     
+ Partials       532      356     -176     
Flag Coverage Δ
bridge ?
bridge-history-api ?
common 63.98% <99.01%> (+1.92%) ⬆️
contracts ?
coordinator 19.93% <ø> (ø)
database 42.85% <ø> (ø)
prover ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinlyguo
Copy link
Member Author

L1 Pos devnet is broken, causing CI failure.

@colinlyguo
Copy link
Member Author

let's wait until the ci has passed.

@colinlyguo colinlyguo merged commit 320ab56 into develop May 7, 2024
14 checks passed
@colinlyguo colinlyguo deleted the feat-codecv1-add-commit-gas-estimation branch May 7, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants