Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-history-api): change redis config #1062

Merged
merged 5 commits into from
Dec 29, 2023

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Dec 29, 2023

Purpose or design rationale of this PR

  1. Add tls encryption in production env.
  2. Add username.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@colinlyguo colinlyguo self-assigned this Dec 29, 2023
@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (693974d) 55.51% compared to head (6a3dbd8) 55.51%.

❗ Current head 6a3dbd8 differs from pull request most recent head cbe68e4. Consider uploading reports for the commit cbe68e4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1062   +/-   ##
========================================
  Coverage    55.51%   55.51%           
========================================
  Files          145      145           
  Lines        11121    11121           
========================================
  Hits          6174     6174           
  Misses        4525     4525           
  Partials       422      422           
Flag Coverage Δ
bridge-history-api 57.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sbaizet-ledger
sbaizet-ledger previously approved these changes Dec 29, 2023
Copy link
Member

@sbaizet-ledger sbaizet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinlyguo colinlyguo merged commit fdb71dd into develop Dec 29, 2023
5 checks passed
@colinlyguo colinlyguo deleted the fix-bridge-history-api-change-config branch December 29, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants