-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): chain monitor server endpoint conflict #1047
fix(test): chain monitor server endpoint conflict #1047
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1047 +/- ##
========================================
Coverage 48.90% 48.90%
========================================
Files 158 158
Lines 12710 12710
========================================
Hits 6216 6216
Misses 6064 6064
Partials 430 430
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I don't think we need to bump version for this PR? |
Yeah. Because i modify too much today. I want build a new version rollup to deploy to sepolia. And just need upgrade the rollup of sepolia to change to chain_monitor api |
Yeah, btw, I think this PR does not affect any binaries, so we don't need to bump version in this PR. |
I bump the version. Because I don't want submit a bump version pr. ahh |
Purpose or design rationale of this PR
Currently, mock chain monitor server's is constant, will conflict when multiple CIs are running in the meantime.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?