Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): chain monitor server endpoint conflict #1047

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Dec 13, 2023

Purpose or design rationale of this PR

Currently, mock chain monitor server's is constant, will conflict when multiple CIs are running in the meantime.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@colinlyguo colinlyguo self-assigned this Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db07180) 48.90% compared to head (4348aed) 48.90%.

❗ Current head 4348aed differs from pull request most recent head 7f65ee1. Consider uploading reports for the commit 7f65ee1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1047   +/-   ##
========================================
  Coverage    48.90%   48.90%           
========================================
  Files          158      158           
  Lines        12710    12710           
========================================
  Hits          6216     6216           
  Misses        6064     6064           
  Partials       430      430           
Flag Coverage Δ
rollup 66.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

georgehao
georgehao previously approved these changes Dec 13, 2023
@colinlyguo colinlyguo requested a review from Thegaram December 13, 2023 08:01
@georgehao georgehao added the bump-version Bump the version tag for deployment label Dec 13, 2023
@0xmountaintop
Copy link
Contributor

I don't think we need to bump version for this PR?

@georgehao
Copy link
Member

georgehao commented Dec 13, 2023

I don't think we need to bump version for this PR?

Yeah. Because i modify too much today. I want build a new version rollup to deploy to sepolia.

And just need upgrade the rollup of sepolia to change to chain_monitor api

@georgehao georgehao merged commit b8c463f into develop Dec 13, 2023
@georgehao georgehao deleted the fix-chain-monitor-unit-test-endpoint-conflict branch December 13, 2023 08:37
@colinlyguo
Copy link
Member Author

I don't think we need to bump version for this PR?

Yeah, btw, I think this PR does not affect any binaries, so we don't need to bump version in this PR.

@georgehao
Copy link
Member

I don't think we need to bump version for this PR?

Yeah, btw, I think this PR does not affect any binaries, so we don't need to bump version in this PR.

I bump the version. Because I don't want submit a bump version pr. ahh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants