Skip to content

Make thread starter messages look nicer #189

Make thread starter messages look nicer

Make thread starter messages look nicer #189

Triggered via push February 24, 2025 15:14
Status Failure
Total duration 2m 33s
Artifacts

linters.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

1 error and 18 warnings
Clippy
Clippy had exited with the 101 exit code
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
field `token` is never read: scripty_webserver/src/auth.rs#L10
warning: field `token` is never read --> scripty_webserver/src/auth.rs:10:6 | 8 | pub struct Authentication { | -------------- field in this struct 9 | /// The token used for auth. 10 | pub token: String, | ^^^^^ | = note: `#[warn(dead_code)]` on by default
called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator: scripty_bot_utils/src/generic_audio_message.rs#L116
warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator --> scripty_bot_utils/src/generic_audio_message.rs:116:53 | 116 | if let Some(ext) = attachment.filename.split('.').last() { | ^^^^^^ help: try: `next_back()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last = note: `#[warn(clippy::double_ended_iterator_last)]` on by default
this function depends on never type fallback being `()`: scripty_bot_utils/src/entity_block.rs#L168
warning: this function depends on never type fallback being `()` --> scripty_bot_utils/src/entity_block.rs:168:1 | 168 | pub async fn add_blocked_guild(guild_id: GuildId, reason: Option<String>) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in Rust 2024 and in a future release in all editions! = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/never-type-fallback.html> = help: specify the types explicitly note: in edition 2024, the requirement `!: scripty_redis::redis::FromRedisValue` will fail --> scripty_bot_utils/src/entity_block.rs:185:4 | 185 | .set( | ^^^ help: use `()` annotations to avoid fallback changes | 185 | .set::<_, _, ()>( | ++++++++++++
this function depends on never type fallback being `()`: scripty_bot_utils/src/entity_block.rs#L138
warning: this function depends on never type fallback being `()` --> scripty_bot_utils/src/entity_block.rs:138:1 | 138 | pub async fn add_blocked_user(user_id: UserId, reason: Option<String>) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in Rust 2024 and in a future release in all editions! = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/never-type-fallback.html> = help: specify the types explicitly note: in edition 2024, the requirement `!: scripty_redis::redis::FromRedisValue` will fail --> scripty_bot_utils/src/entity_block.rs:155:4 | 155 | .set( | ^^^ help: use `()` annotations to avoid fallback changes | 155 | .set::<_, _, ()>( | ++++++++++++
this function depends on never type fallback being `()`: scripty_bot_utils/src/entity_block.rs#L8
warning: this function depends on never type fallback being `()` --> scripty_bot_utils/src/entity_block.rs:8:1 | 8 | pub async fn init_blocked() -> Result<(), scripty_redis::redis::RedisError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in Rust 2024 and in a future release in all editions! = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/never-type-fallback.html> = help: specify the types explicitly note: in edition 2024, the requirement `!: scripty_redis::redis::FromRedisValue` will fail --> scripty_bot_utils/src/entity_block.rs:34:5 | 34 | .query_async(&mut redis_pool) | ^^^^^^^^^^^ = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default help: use `()` annotations to avoid fallback changes | 34 ~ .query_async::<_, ()>(&mut redis_pool) 35 | .await?; ... 54 | .ignore() 55 ~ .query_async::<_, ()>(&mut redis_pool) |
this function has too many arguments (10/7): scripty_audio_handler/src/events/driver_disconnect.rs#L17
warning: this function has too many arguments (10/7) --> scripty_audio_handler/src/events/driver_disconnect.rs:17:1 | 17 | / pub async fn driver_disconnect( 18 | | guild_id: GuildId, 19 | | reason: Option<DisconnectReason>, 20 | | ctx: Context, ... | 27 | | ephemeral: bool, 28 | | ) { | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (10/7): scripty_audio_handler/src/audio_handler.rs#L79
warning: this function has too many arguments (10/7) --> scripty_audio_handler/src/audio_handler.rs:79:2 | 79 | / pub async fn new( 80 | | guild_id: GuildId, 81 | | webhook: Webhook, 82 | | context: Context, ... | 89 | | ephemeral: bool, 90 | | ) -> Result<Self, Error> { | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
unused variable: `auto_detect_lang`: scripty_audio_handler/src/events/voice_tick.rs#L148
warning: unused variable: `auto_detect_lang` --> scripty_audio_handler/src/events/voice_tick.rs:148:3 | 148 | auto_detect_lang, | ^^^^^^^^^^^^^^^^ help: try ignoring the field: `auto_detect_lang: _` | = note: `#[warn(unused_variables)]` on by default
this function depends on never type fallback being `()`: scripty_audio_handler/src/connect.rs#L29
warning: this function depends on never type fallback being `()` --> scripty_audio_handler/src/connect.rs:29:1 | 29 | / pub async fn connect_to_vc( 30 | | ctx: Context, 31 | | guild_id: GuildId, 32 | | transcript_target_channel: ChannelId, ... | 36 | | ephemeral: bool, 37 | | ) -> Result<(), Error> { | |______________________^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in Rust 2024 and in a future release in all editions! = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/never-type-fallback.html> = help: specify the types explicitly note: in edition 2024, the requirement `!: scripty_redis::redis::FromRedisValue` will fail --> scripty_audio_handler/src/connect.rs:210:2 | 210 | / scripty_redis::run_transaction("SET", |f| { 211 | | f.arg(format!("voice:{{{}}}:webhook_token", guild_id)) 212 | | .arg(webhook_token.expose_secret()) 213 | | .arg("EX") 214 | | .arg(leave_delta + 5); 215 | | }) | |______^ = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default help: use `()` annotations to avoid fallback changes | 210 ~ scripty_redis::run_transaction::<()>("SET", |f| { 211 | f.arg(format!("voice:{{{}}}:webhook_token", guild_id)) ... 216 | .await?; 217 ~ scripty_redis::run_transaction::<()>("SET", |f| { |
field `message` is never read: scripty_botlists/src/lists/disforge_com/models.rs#L9
warning: field `message` is never read --> scripty_botlists/src/lists/disforge_com/models.rs:9:6 | 7 | pub struct PostStatsResponse { | ----------------- field in this struct 8 | pub status: String, 9 | pub message: String, | ^^^^^^^ | = note: `PostStatsResponse` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/