feat: Add template composition example for template; add notifications validation err flag #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s validation err flag
jithine
reviewed
Feb 8, 2021
There was a problem hiding this comment.
Also this example is misplaced https://github.com/screwdriver-cd/guide/pull/450/files#diff-0863375e9d888a75cabce90e1d0e8b16a72cb690efab345548edfd00bb842926R261-R302
It's under the main title of Template Composition but the example is for usage of order in a job. I would rather flip the precedence, provide example which shows order usage in Template Composition and just leave a note that order can also used in jobs. (I would rather not highlight order availability for jobs since only power users should have this kind of flexibility )
docs/user-guide/templates.md
Outdated
| url: "#writing-a-template-yaml" | ||
| subitem: true | ||
| - title: Template images | ||
| url: "template-images" |
jithine
reviewed
Feb 9, 2021
jithine
reviewed
Feb 9, 2021
docs/user-guide/templates.md
Outdated
| url: "#template-composition" | ||
| subitem: true | ||
| - title: Writing a screwdriver yaml | ||
| url: "#writing-a-screwdriveryaml" |
There was a problem hiding this comment.
jithine
reviewed
Feb 9, 2021
| ### Template Composition | ||
| You can also use a template in the `config` section of an `sd-template.yaml` file. | ||
|
|
||
| Caveats: |
There was a problem hiding this comment.
change to Caveats when using order ?
jithine
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This PR: addd template composition for template example, updated template TOC, and adds notifications validation err flag and other API settings.
References
Related to screwdriver-cd/screwdriver#2319, screwdriver-cd/screwdriver#2339
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.