fix: Change setNodeSelector to use a single nodeSelectorTerm #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Our current implementation of
setNodeSelectorappends multiplenodeSelectorTermsto the spec. This leads to anORscheduling behavior where the pod can be scheduled on any node that is labled with any of thenodeSelectors.I believe we desire an
ANDscheduling behavior where the pod can be scheduled on any node that is labled with ALL of thenodeSelectors. This PR changes the implementation ofsetNodeSelectorto honor thisANDbehavior of scheduling.Objective
Update
setNodeSelectorto append multiple keys to a singlenodeSelectorTermReferences
screwdriver-cd/screwdriver#757
https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#nodeselector
kubernetes/kubernetes#44349
screwdriver-cd/executor-k8s-vm#43