fix(2331): Pass locked job steps [2.5] #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pritamstyz4ever
approved these changes
Feb 23, 2021
jithine
reviewed
Feb 23, 2021
| @@ -13,7 +13,7 @@ const SCHEMA_JOB_COMMAND = Joi.object() | |||
| name: Joi.string(), | |||
| command: Joi.string() | |||
| }) | |||
| .unknown(false) | |||
There was a problem hiding this comment.
should we just add locked as optional here, instead of allowing unknown ?
jithine
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Would be nice if the UI could show locked steps in a job when template is used.
Objective
This PR allows more data to be sent from config parser through commands so locked step can be shown in the UI.
References
Related to screwdriver-cd/screwdriver#2331
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.