Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of StructureLab.mineralType #73

Merged
merged 2 commits into from
May 23, 2018
Merged

Fix type of StructureLab.mineralType #73

merged 2 commits into from
May 23, 2018

Conversation

pmoehl
Copy link
Contributor

@pmoehl pmoehl commented May 21, 2018 •
edited
Loading

Brief Description

The actual type of StructureLab.mineralType is null and not undefined if a lab is empty. The preferred tripple equal operator lab.mineralType === undefined would always evaluate to false.

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run dtslint to update index.d.ts

@dmarcuse dmarcuse merged commit 4d3e014 into screepers:master May 23, 2018
@pmoehl pmoehl deleted the lab-mineral-type branch May 23, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmarcuse dmarcuse dmarcuse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmoehl @dmarcuse