Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update findClosestByPath to make filter options partial #179

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

ngbrown
Copy link
Contributor

@ngbrown ngbrown commented Sep 10, 2020

Brief Description

The filter in the options isn't required for findClosestByPath.

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run dtslint to update index.d.ts

Copy link
Member

@pyrodogg pyrodogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please address the line comment. Also, add some tests for the newly updated properties in dist/screeps-tests.ts and run npm run dtslint to update the dist/index.d.ts file

src/room-position.ts Outdated Show resolved Hide resolved
Complete definition of findClosestByPath
@pyrodogg pyrodogg merged commit e5cc321 into screepers:master Sep 17, 2020
@ngbrown ngbrown deleted the patch-1 branch September 20, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants