Implements Room.Terrain and room.getTerrain() #103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
This PR implements the Room.Terrain interface which allows getting the RoomTerrain object for any room, regardless of room visibility.
const terrain = new Room.Terrain("W2N5");
It also implements the room.getTerrain() method which allows getting the RoomTerrain object for any room object.
const terrain = room.getTerrain();
Closes #102
It looks like prettier updated a bunch of random things in the screeps-test class.
I experienced a situation where tslint and prettier appeared to be fighting over a few instances of the 'newline-per-chained-call' rule in the screeps-tests.ts file. If I fixed the error to appease tslint, it would get auto-changed on save into an incorrect state again. I opted to disable the tslint rule for the 4 cases since eslint says, "[i]f you have conflicting rules...you can safely turn this rule off." It seems like adding prettier to the project is fairly recent. I'm open to feedback on better ways to improve this situation.
Checklists
src/
files notindex.d.ts
npm run dtslint
to updateindex.d.ts