Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed eventLog to getEventLog(). #101

Merged
merged 4 commits into from
Oct 10, 2018

Conversation

BarryOSeven
Copy link

@BarryOSeven BarryOSeven commented Oct 10, 2018

Brief Description

  • Changed eventLog to getEventLog(raw?: boolean)
  • Added constants for events
  • Added tests for getEventLog().

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run dtslint to update index.d.ts

@BarryOSeven BarryOSeven reopened this Oct 10, 2018
@Jomik
Copy link
Contributor

Jomik commented Oct 10, 2018

I think it would be nice to update the return types as well:

type EventConstant =

Specifically
type EventItem = {

@BarryOSeven
Copy link
Author

The return types need an update.

@BarryOSeven BarryOSeven reopened this Oct 10, 2018
@Jomik
Copy link
Contributor

Jomik commented Oct 10, 2018

Quick scan through - seems to me like this completes EventLog.

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we can also easily clean up the object types in EventItem, but we'll leave that for another time!

@resir014 resir014 merged commit 7965944 into screepers:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants