Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update got to the latest version 🚀 #585

Closed
wants to merge 1 commit into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented May 29, 2017

Version 7.0.0 of got just got published.

Dependency got
Current Version 5.7.1
Type devDependency

The version 7.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of got.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Release Notes 7.0.0

Breaking changes

  • Changes stringifying options behavior. 51a3eaf
    Setting the body option to be an object to stringify is no longer possible without setting either the form option for URL encoding or the json option for JSON encoding. Previously, Got would use URL encoding by default, now it will throw an error. Since the json option also means Got will decode a JSON response for you, setting both options to true will encode the request as URL and decode the response as JSON.
  • Now also redirects on 307, 308, 303 responses. b45896a
  • The timeout option now applies to the whole request and we added ability to control the timeout of the individual phases. 7964f2c

Highlights

  • Added ability to cancel in-progress requests! 9ef7a5a
  • Added WHATWG URL support. f501fc2
  • Improve request retries by reducing the number of retries and making delays shorter. 14d0859
  • Only throws ParseError when parsing fails on 2xx responses. c86706b
  • No longer throws HTTPError on 304 responses. 7b12b75
  • Added protocol property to errors. 919703c
  • Added url property to errors. a287f8e
  • Includes response headers in errors, and redirect URLs in errors and the response. 8b4d06e
  • Improve use in Electron. 2130570 6fc1902

All changes

v6.7.1...v7.0.0

Commits

The new version differs by 157 commits ahead by 157, behind by 39.

  • c20bc5e 7.0.0
  • 6fc1902 Add ability to opt-out of using electron.net
  • 7964f2c Request timeout (#308)
  • b45896a Redirect on 307, 308, 303 (#307)
  • a299b00 Set up proxy event emitter before making a request (#304)
  • 2130570 Improve use in Electron (#311)
  • 359a5d1 Use class syntax for errors (#306)
  • f501fc2 Add WHATWG URL support (#289)
  • ff0cef0 Tiny cleanup
  • 9ef7a5a Add ability to cancel in-progress requests (#287)
  • c86706b Only throw ParseError on 2xx responses (#301)
  • 8b4d06e Include response headers and redirect URLs in error object (#302)
  • 6d19a72 Bump some devDependencies
  • 578f38d Set url and requestUrl directly on the response (#300)
  • 14d0859 reduce retries number and make delays shorter (#299)

There are 157 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented May 29, 2017

Version 7.0.0 just got published.

Update to this version instead 🚀

Release Notes 7.0.0

Breaking changes

  • Changes stringifying options behavior. 51a3eaf
    Setting the body option to be an object to stringify is no longer possible without setting either the form option for URL encoding or the json option for JSON encoding. Previously, Got would use URL encoding by default, now it will throw an error. Since the json option also means Got will decode a JSON response for you, setting both options to true will encode the request as URL and decode the response as JSON.
  • Now also redirects on 307, 308, 303 responses. b45896a
  • The timeout option now applies to the whole request and we added ability to control the timeout of the individual phases. 7964f2c

Highlights

  • Added ability to cancel in-progress requests! 9ef7a5a
  • Added WHATWG URL support. f501fc2
  • Improve request retries by reducing the number of retries and making delays shorter. 14d0859
  • Only throws ParseError when parsing fails on 2xx responses. c86706b
  • No longer throws HTTPError on 304 responses. 7b12b75
  • Added protocol property to errors. 919703c
  • Added url property to errors. a287f8e
  • Includes response headers in errors, and redirect URLs in errors and the response. 8b4d06e
  • Improve use in Electron. 2130570 6fc1902

All changes

v6.7.1...v7.0.0

Commits

The new version differs by commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Jun 30, 2017
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jun 30, 2017

Version 7.1.0 just got published.

Update to this version instead 🚀

Commits

The new version differs by 17 commits ahead by 17, behind by 1.

  • b725ef5 7.1.0
  • 1da85aa Bump p-cancelable
  • 8bb556a Bump AVA
  • c0c6bcf Fix unix address parser (#339)
  • f535947 Escape dot in regex in a test
  • 1cf2bbf Support Array with the json option (#335)
  • ee405f4 Add all helper functions in the same loop (#336)
  • 8660ab7 Add test for err.response.body
  • 3f11737 url arg optimizations (#329)
  • 4e1b0bf Fix readme highlight link
  • f735bdd Bump dev dependencies
  • 049a050 Add a feature highlight section to the readme (#326)
  • 17e24e9 Remove nonexistent strictSSL option from test (#328)
  • f9d19e3 Add decompress option (#320)
  • ae1804b Update .travis.yml

There are 17 commits in total.

See the full diff

@rschamp
Copy link
Contributor

rschamp commented Jul 26, 2017

@cwillisf Instead of upgrading this, what do you think about switching got out for xhr or nets (uses xhr client-side or request for Node (same API for both libraries)), so that we didn't have multiple choices for making requests across repos?

@rschamp rschamp added this to the Aug 23 milestone Jul 26, 2017
@cwillisf
Copy link
Contributor

@rschamp, that makes sense to me. Is there any reason to prefer either xhr or nets over the other?

@rschamp
Copy link
Contributor

rschamp commented Jul 26, 2017

The main consideration is that if you're going to build for both web and Node, then nets allows you to use one library for both, so that's probably what we would want to go with for scratch-vm.

@rschamp
Copy link
Contributor

rschamp commented Jul 26, 2017

(And when we do that, we should do the same for scratch-storage, which I just noticed doesn't have Greenkeeper enabled >:) )

@cwillisf
Copy link
Contributor

Ah, I mis-parsed your initial comment. I see what you were saying now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants