Skip processing of child paths in mergeEraser #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
force-pushed
the
mergeeraser-skip-child-paths
branch
from
c773a65 to
1952b90
Compare
adroitwhiz
force-pushed
the
mergeeraser-skip-child-paths
branch
from
1952b90 to
41e0765
Compare
|
Wow, that looks great! |
fsih
approved these changes
Apr 24, 2020
fsih
reviewed
Apr 24, 2020
| // If a path is part of a compound path, that parent path will later be processed. | ||
| // Skip processing the child path so as not to double-process it. | ||
| if (isCompoundPathChild(items[i])) continue; | ||
|
|
||
| // TODO handle compound paths |
There was a problem hiding this comment.
Maybe that's what this comment was referring to? =_=;
There was a problem hiding this comment.
I was wondering about that... is it okay to remove those comments then?
There was a problem hiding this comment.
We're handling them now, so I guess so!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #621
Resolves #120
Resolves #119
Proposed Changes
This PR modifies the shape Boolean processing loop in
Blobbiness.mergeEraserto skip processing paths that are children of compound paths.Reason for Changes
Both child paths and their parents are included in the list of items that
mergeEraserwill attempt to merge with. If child paths are not specifically excluded,mergeEraserwill attempt to operate on them twice: once with their parent path, and one with them on their own.Fixing this greatly improves the reliability of eraser operations: