Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit stroke width to 100 #796

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Conversation

fsih
Copy link
Contributor

@fsih fsih commented Dec 13, 2018

Resolves

Fixes #768

Proposed Changes

Change the max stroke width to 100
I also bumped up the size of the stroke input so that it doesn't show '...' when you type in 100

Reason for Changes

Strokes do really weird things when they're thick

Test Coverage

Please show how you have added tests to cover your changes

@fsih fsih added this to the December 2018 milestone Dec 13, 2018
@fsih fsih requested a review from benjiwheeler December 13, 2018 20:29
Copy link
Contributor

@benjiwheeler benjiwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM!

@benjiwheeler benjiwheeler assigned fsih and unassigned benjiwheeler Dec 14, 2018
@fsih fsih merged commit 1a81788 into scratchfoundation:develop Dec 14, 2018
@fsih fsih deleted the strokeLimit branch December 14, 2018 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants