Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Call
ci-cd.yml
workflow from a job instead of a step, since GHA doesn't allow calling a workflow from a step 😅Also, use
git push
instead ofgit push origin master
when pushing changes in theCommit translation updates
step. When running the daily job this won't change behavior, but it does allow testing thedaily-tx-pull
workflow without contaminating themaster
branch.Speaking of testing, check this out: https://github.com/scratchfoundation/scratch-l10n/actions/runs/6961962062
Note that the
ci-cd.yml
workflow was set up to fail early on that run to save time. The important part is thatci-cd.yml
ran at all. Woo!