Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow call #187

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fix workflow call #187

merged 2 commits into from
Nov 22, 2023

Conversation

cwillisf
Copy link
Contributor

Proposed Changes

Call ci-cd.yml workflow from a job instead of a step, since GHA doesn't allow calling a workflow from a step 😅

Also, use git push instead of git push origin master when pushing changes in the Commit translation updates step. When running the daily job this won't change behavior, but it does allow testing the daily-tx-pull workflow without contaminating the master branch.

Speaking of testing, check this out: https://github.com/scratchfoundation/scratch-l10n/actions/runs/6961962062

Note that the ci-cd.yml workflow was set up to fail early on that run to save time. The important part is that ci-cd.yml ran at all. Woo!

@cwillisf cwillisf requested a review from skripted-io November 22, 2023 19:57
Copy link
Contributor

@skripted-io skripted-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@cwillisf cwillisf merged commit 8bea2cc into master Nov 22, 2023
@cwillisf cwillisf deleted the fix-cicd-workflow-call branch November 22, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants