Clean up of fields; have floating div render entire text box during edit #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also this possibly fixes #34 (RTL) - anything else to do on that front? |
| 'font-family: sans-serif;', | ||
| 'height: 100%;', | ||
| 'margin: 0;', | ||
| 'outline: none;', | ||
| 'padding: 0 1px;', | ||
| 'padding: 2px 0px;', |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Few nits then lgtm |
|
Magic numbers: https://imgur.com/FIcsv60 |
picklesrus
pushed a commit
to picklesrus/scratch-blocks
that referenced
this pull request
Aug 4, 2017
Affects SpriteSelector Pane, StageSelector Pane, Stage, MenuBar, Libraries Modal, Add/Import buttons, for Chrome, Ffx + Safari on Sierra. Fixes scratchfoundation#162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Removes borderRect_ altogether as we're not using this.
-Fixes up positioning of fields. Instead of borderRect_, the click target (field path/shadow block) is now the "master copy" of the field position and size.
-Move some logic around border radii and colors for the fields so that we can access these properties when drawing the CSS-styled box.
-Finally, in field_textinput, implement the drawing, sizing, and styling for the CSS-styled floating div box.
The goal for this PR is to allow us to do animations on the box once it's focused. It makes it easier for us to customize and style text fields being edited.
I know the positioning of the box has a lot of magic numbers - as it did before. I'm pretty convinced it's as good as it's going to get, and I don't have great justifications for the numbers except for fiddling in each browser.