Increase active area on one-field-blocks #132 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a block only has one field, the mouseup event (which triggers editing of editable fields) will be bound to the block instead of the field. Fixes #132.
|
This seems to me like a fine solution at least in the interim until we start doing vertical rendering and/or refactor/rethink the way we drew fields. Can you think of any way to fix the mouse cursor? When you get a chance, please go ahead and merge! |
We do this by applying the style to the same element we apply the click target to, ie the whole block if it only has one field.
picklesrus
pushed a commit
to picklesrus/scratch-blocks
that referenced
this pull request
Aug 4, 2017
SpriteInfo: Design + refactor pass * Updated SVG icons * Added tab indexes, related scratchfoundation#88. Still no tab on radio buttons * Removed outline on dropdown focus * Radio icons: fixed redirecting issue, using `div` instead of `a`. Temporary, until radio buttons. Related scratchfoundation#156 * All icons: unselectable to prevent highlighting. Radio icons clickable * SpriteSelector: fixed bottom padding in scroll wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a block only has one field, the mouseup event (which triggers editing
of editable fields) will be bound to the block instead of the field.
Fixes #132.
The test breaks from the style of the existing tests by requiring a lot of infrastructure to work, as we have to actually create the whole SVG workspace before we can install the click handler on an SVG element. If you don't like this, I could cut the test or maybe try to mock enough to test just the event handling? Let me know.