Change url from required to optional parameter for SplashRequest #324
+23
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…require scrapy >= 2.4
Gallaecio
reviewed
Jan 29, 2025
Gallaecio
approved these changes
Jan 29, 2025
protokoul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve #270 and resolve #271
Change
urlfromoptional to requiredrequired to optional parameter forSplashRequestby reverting this commit 4154782Scrapy >= 2.4 set in
tox.ini andsetup.pyRemoved code in
scrapy_splash/utils.pyto check if scrapy version is >= 2