Don't create unused temporary file on every plugin initialization #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…very plugin initialization.
sksamuel
added a commit
that referenced
this pull request
Mar 11, 2015
Don't create unused temporary file on every plugin initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScoverageOptions.dataDirparameter is initialized with valueFile.createTempFile("scoverage_datadir_not_defined", ".tmp").getParent.Setting
dataDiris required in Scalac plugin parameters (-P:scoverage:dataDir:<pathtodatadir>), if not set exception will be thrown, so ANY initial value is OK because it will be overwritten anyway. UsingFile.createTempFileto initialize causes temporaryscoverage_datadir_not_defined<random_hash>.tmpfile creation as a side effect (this file will never be used) so it's not the best choice.