Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish for Scala 2.12.0-RC2 #188

Closed
SethTisue opened this issue Oct 19, 2016 · 3 comments
Closed

publish for Scala 2.12.0-RC2 #188

SethTisue opened this issue Oct 19, 2016 · 3 comments

Comments

@SethTisue
Copy link

SethTisue commented Oct 19, 2016

pretty please :-)

@gslowikowski
Copy link
Member

Waiting for Scala Logging (lightbend-labs/scala-logging#61)

gslowikowski added a commit that referenced this issue Oct 19, 2016
- Scala version upgraded from 2.12.0-RC1 to 2.12.0-RC2,
- ScalaJS version upgraded from 0.6.12 to 0.6.13.
@gslowikowski
Copy link
Member

After upgrading ScalaJS version to 0.6.13 I have exceptions thrown from runtimeJS module tests:

[info] InvokerMultiModuleTest:
[info] scoverage.InvokerMultiModuleTest *** ABORTED ***
[info]   scala.scalajs.js.JavaScriptException: Error: EBUSY: resource busy or locked, unlink '{mypath}\target\invoker-test.measurement0\scoverage.measurements.28'
[info]   at Error@native(Unknown Source)
[info]   at Object.fs.unlinkSync(fs.js:932:18)
[info]   at scalajssupport.NodeFile.$delete({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:22685:41)
[info]   at scoverage.InvokerMultiModuleTest.scoverage$InvokerMultiModuleTest$$deleteMeasurementFiles({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:51645:25)
[info]   at scoverage.InvokerMultiModuleTest$$anonfun$1.apply$mcV$sp({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:43206:18)
[info]   at scoverage.InvokerMultiModuleTest$$anonfun$1.apply({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:43219:8)
[info]   at org.scalatest.BeforeAndAfter$class.runTest({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:1141:13)
[info]   at scoverage.InvokerMultiModuleTest.runTest({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:51627:10)
[info]   at {anonymous}()({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:2924:24)
[info]   at scala.scalajs.runtime.AnonFunction2.apply({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:29406:23)
[info]   ...
scala.scalajs.js.JavaScriptException: Error: EBUSY: resource busy or locked, unlink '{mypath}\target\invoker-test.measurement0\scoverage.measurements.28'
    at <jscode>.Error@native(Unknown Source)
    at <jscode>.Object.fs.unlinkSync(fs.js:932)
    at scalajssupport.NodeFile.$delete({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:22685)
    at scoverage.InvokerMultiModuleTest.scoverage$InvokerMultiModuleTest$$deleteMeasurementFiles({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:51645)
    at scoverage.InvokerMultiModuleTest$$anonfun$1.apply$mcV$sp({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:43206)
    at scoverage.InvokerMultiModuleTest$$anonfun$1.apply({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:43219)
    at org.scalatest.BeforeAndAfter$class.runTest({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:1141)
    at scoverage.InvokerMultiModuleTest.runTest({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:51627)
    at <jscode>.{anonymous}()({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:2924)
    at scala.scalajs.runtime.AnonFunction2.apply({mypath}\scalac-scoverage-runtime\js\target\scala-2.11\scalac-scoverage-runtime-test-fastopt.js:29406)

The problem is in scalajssupport.NodeFile.$delete method. Before ScalaJS 0.6.13 node environment was not used by default, but that has changed on 6 Sep 2016 in this commit.

Because I don't know, how to fix it, I can set Rhino environment in tests as it was by default before ScalaJS 0.6.13.

The real problem with NodeFile class can be investigated and fixed later (it's not related to Scala 2.12.0-RC2).

gslowikowski added a commit that referenced this issue Oct 19, 2016
@gslowikowski
Copy link
Member

Published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants