-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support scala 2.12.13, replaced deprecated sbt syntax #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments on things that I don't believe we need. I'm also still a bit concerned about the _sjs
stuff since I believe we are forcing 1.5.x
when shouldn't it only be for 1.x.x
?
Also to verify I also changed
to just take 1 to align with the compiler plugin and all seems to work as expected. |
+1 on the sjs Version format. |
@ckipp01 So all thats left is a published scoverage and an updated version in here. |
Perfect. I'll do a release of the compiler plugin here shortly and then we should be able to update the version here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton on your help getting this across the finish line @domizei385. I've updated to the newly released version of scoverage and all seems to be passing. I'll go ahead and merge and kickstart a release.
removed sbt 0.13.x support
PR #2 for scoverage/scalac-scoverage-plugin#305