Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scala 2.12.13, replaced deprecated sbt syntax #324

Merged
merged 3 commits into from
Apr 28, 2021

Conversation

domizei385
Copy link
Contributor

@domizei385 domizei385 commented Apr 27, 2021

removed sbt 0.13.x support
PR #2 for scoverage/scalac-scoverage-plugin#305

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments on things that I don't believe we need. I'm also still a bit concerned about the _sjs stuff since I believe we are forcing 1.5.x when shouldn't it only be for 1.x.x?

.github/workflows/pr.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
src/sbt-test/scoverage/aggregate-only/project/plugins.sbt Outdated Show resolved Hide resolved
src/sbt-test/scoverage/aggregate/project/plugins.sbt Outdated Show resolved Hide resolved
src/sbt-test/scoverage/bad-coverage/project/plugins.sbt Outdated Show resolved Hide resolved
src/sbt-test/scoverage/coverage-off/project/plugins.sbt Outdated Show resolved Hide resolved
src/sbt-test/scoverage/scalajs/build.sbt Outdated Show resolved Hide resolved
@ckipp01
Copy link
Member

ckipp01 commented Apr 28, 2021

Also to verify I also changed

}.map(_.take(3)).map(sjsVersion => "_sjs" + sjsVersion)

to just take 1 to align with the compiler plugin and all seems to work as expected.

@domizei385
Copy link
Contributor Author

+1 on the sjs Version format.
Just aligned the plugin with the new convention and running tests now.

@domizei385
Copy link
Contributor Author

@ckipp01 So all thats left is a published scoverage and an updated version in here.

@ckipp01
Copy link
Member

ckipp01 commented Apr 28, 2021

+1 on the sjs Version format.
Just aligned the plugin with the new convention and running tests now.

Perfect. I'll do a release of the compiler plugin here shortly and then we should be able to update the version here.

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton on your help getting this across the finish line @domizei385. I've updated to the newly released version of scoverage and all seems to be passing. I'll go ahead and merge and kickstart a release.

@ckipp01 ckipp01 merged commit fe21a51 into scoverage:master Apr 28, 2021
@domizei385 domizei385 deleted the updates branch April 28, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants